Quantcast
Channel: Node.js Tools for Visual Studio
Viewing all articles
Browse latest Browse all 4630

Commented Issue: Incomplete code causes exception [1661]

$
0
0
Run this in the editor (or parse it) and will fail
```
var express = require('express'), app =
var app = express.cre
```

```
System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. Parameter name: span at Microsoft.VisualStudio.Text.Implementation.SimpleStringRebuilder.GetText(Span span) at Microsoft.VisualStudio.Text.Implementation.TextSnapshot.GetText(Span span) at Microsoft.NodejsTools.Classifier.NodejsClassifier.IsKeywordInIdentifierContext(ITextSnapshot snapshot, Nullable`1 prevToken, Nullable`1 prevPrevToken, TokenInfo token, Int32 lineNumber) at Microsoft.NodejsTools.Classifier.NodejsClassifier.AddClassifications(JSScanner JSScanner, List`1 classifications, SnapshotSpan span) at Microsoft.NodejsTools.Classifier.NodejsClassifier.GetClassificationSpans(SnapshotSpan span) at Microsoft.VisualStudio.Text.Classification.Implementation.ClassifierTagger.<GetTags>d__0.MoveNext() at Microsoft.VisualStudio.Text.Tagging.Implementation.TagAggregator`1.<GetTagsForBuffer>d__5.MoveNext() Editor or Editor Extension 2014/12/19 22:21:58.386
1080 ERROR System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. Parameter name: span at Microsoft.VisualStudio.Text.Implementation.SimpleStringRebuilder.GetText(Span span) at Microsoft.VisualStudio.Text.Implementation.TextSnapshot.GetText(Span span) at Microsoft.NodejsTools.Classifier.NodejsClassifier.IsKeywordInIdentifierContext(ITextSnapshot snapshot, Nullable`1 prevToken, Nullable`1 prevPrevToken, TokenInfo token, Int32 lineNumber) at Microsoft.NodejsTools.Classifier.NodejsClassifier.AddClassifications(JSScanner JSScanner, List`1 classifications, SnapshotSpan span) at Microsoft.NodejsTools.Classifier.NodejsClassifier.GetClassificationSpans(SnapshotSpan span) at Microsoft.VisualStudio.Text.Classification.Implementation.ClassifierTagger.<GetTags>d__0.MoveNext() at Microsoft.VisualStudio.Text.Tagging.Implementation.TagAggregator`1.<GetTagsForBuffer>d__5.MoveNext()

```
Comments: This is fixed. The underlying issue was that lines that were incomplete and followed by var or operators and vars were evaluating the span/token placement causing us to run off of the snapshot. This should be fixed now. Test cases were added for both of the below scenarios. ``` /*some comment to make long line*/ var incomplete = var ``` or ``` /*some comment to make long line*/ var incomplete var var ```

Viewing all articles
Browse latest Browse all 4630

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>